Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1357662 - Add support for toggling log timestamps on web console
Summary: Add support for toggling log timestamps on web console
Keywords:
Status: NEW
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: RFE
Version: 3.3.0
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
: ---
Assignee: Jessica Forrester
QA Contact: Johnny Liu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-18 19:43 UTC by Mike Fiedler
Modified: 2019-02-11 18:14 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Mike Fiedler 2016-07-18 19:43:16 UTC
Description of problem:

In 3.3 log timestamps are not displayed by default.  --timestamps must be added to get them on the CLI.   This "breaks" the web console in my opinion.  There is no option there to enable timestamps and the timestamps are valuable information in logs.

We should consider reverting to 3.2 behavior and turn the timestamps on.   The timestamp format has also changed in 3.3.

Version-Release number of selected component (if applicable):

3.3.0.6

How reproducible: Always


Steps to Reproduce:
1.  Log in to the web UI
2.  Build an application
3.  Go to the build log


Actual results:

No timestamps in the build log


Expected results:

Timestamps in the build log to assist in application development troubleshooting.

Comment 1 Mike Fiedler 2016-07-18 19:44:33 UTC
Changing component to CLI - Logging was incorrect since that is the EFK stack.

Comment 2 Fabiano Franz 2016-07-19 18:02:57 UTC
Timestamps support come from the container, depending on how the build expose it or not. Turning into a RFE to add support for toggling timestamps on the web console.

Comment 3 Mike Fiedler 2016-07-19 19:37:32 UTC
This is a regression from 3.2 - the API should not have changed.  I think this needs to be a bug on someone.

Comment 4 Jessica Forrester 2016-07-19 20:55:02 UTC
The API did not change, it never returned timestamps.  I think possibly the builds themselves changes to stop returning timestamps.

Comment 5 Mike Fiedler 2016-07-19 23:42:23 UTC
In 3.2, do the following:

oc new-app --template=cakephp-example
oc logs -f bc/cakephp-example

you get timestamps


In 3.3:

oc new-app --template=cakephp-example
oc logs -f bc/cakephp-example

no timestamps

Comment 6 Ben Parees 2016-07-20 12:40:08 UTC
Removing timestamps from build log output was a conscious decision to align build logs with other pod logs.  If you want timestamps you use oc logs foo --timestamps, so builds themselves should not be injecting tiemstamps.

So it's not a regression, it's a feature :)

I agree that a toggle to display timestamps in the console would be a nice feature (applicable to all logs, not just build logs).

Comment 7 Steve Speicher 2016-09-13 16:55:44 UTC
(In reply to Ben Parees from comment #6)
> Removing timestamps from build log output was a conscious decision to align
> build logs with other pod logs.  If you want timestamps you use oc logs foo
> --timestamps, so builds themselves should not be injecting tiemstamps.
> 
> So it's not a regression, it's a feature :)
> 
> I agree that a toggle to display timestamps in the console would be a nice
> feature (applicable to all logs, not just build logs).

+1, in fact I'd say the default in Web UI for build logs should be --timestamp and possibly a way to turn it off. Then there is no regression in Web UI and a way to tidy up the logs, if desire to remove timestamp. Perhaps the customization could even be a separate "build with options" feature, which user could change log levels, add per build env vars, flags, etc

Comment 8 Ben Parees 2016-09-13 17:03:03 UTC
I think calling it a "regression" is unfairly characterizing the change and implying something is broken.  There was a conscious decision made that timestamps are ugly clutter for most users and they should not be displayed by default.  I don't see a reason to reverse that decision.  I agree that giving users the ability to turn on timestamps makes sense.

Most users are not profiling build performance in the way you are (and again, if they want to do that, there are ways for them to see the timestamps)

As for build with options, +1, those are things that exist in "oc start-build" and it's reasonable in my mind for the console to expose them.

Comment 9 Jessica Forrester 2016-09-13 17:09:37 UTC
There is an existing card for build with options https://trello.com/c/nTtovDHM that has been languishing in the backlog for some time now.


Note You need to log in before you can comment on or make changes to this bug.