Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1356250 - QCI 1.2: Invalid ip address in DHCP ranges causes stack trace
Summary: QCI 1.2: Invalid ip address in DHCP ranges causes stack trace
Keywords:
Status: POST
Alias: None
Product: Red Hat Quickstart Cloud Installer
Classification: Red Hat
Component: fusor-installer
Version: 1.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Jason Montleon
QA Contact: Dave Johnson
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-13 19:56 UTC by James Olin Oden
Modified: 2016-07-15 13:53 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description James Olin Oden 2016-07-13 19:56:56 UTC
Description of problem:
I entered, 300.168.175.0 as the DHCP range start:

Modify settings as needed, and then proceed with the installation:
1.      Proceed with the values shown
2.           Network interface | eth1
3.                    Hostname | b.b.b
4.                  IP address | 192.168.175.10
5.                Network mask | 255.255.255.0
6.                Host gateway | 192.168.175.1
7.        DHCP network address | 192.168.175.0
8.            DHCP range start | 300.1689.175.11
9.              DHCP range end | 192.168.175.254
10.               DHCP gateway | 192.168.175.1
11.              DNS forwarder | 192.168.175.10
12.                     Domain | b.b
13.              NTP sync host | 0.rhel.pool.ntp.org
14.                  Time zone | America/New_York
15.  Register Host For Updates | false
16.        BMC feature enabled | false
17.       BMC default provider | ipmitool
18. Do not configure networking
19. Do not configure firewall
20. Cancel installation

And then selected 1 to apply the changes, and the following stack trace occured:
/usr/share/ruby/ipaddr.rb:529:in `block in in_addr': invalid address (IPAddr::InvalidAddressError)
        from /usr/share/ruby/ipaddr.rb:528:in `each'
        from /usr/share/ruby/ipaddr.rb:528:in `inject'
        from /usr/share/ruby/ipaddr.rb:528:in `in_addr'
        from /usr/share/ruby/ipaddr.rb:490:in `initialize'
        from /usr/share/fusor-installer/hooks/lib/provisioning_wizard.rb:285:in `new'
        from /usr/share/fusor-installer/hooks/lib/provisioning_wizard.rb:285:in `validate_ip'
        from /usr/share/fusor-installer/hooks/lib/base_wizard.rb:63:in `block in validate'
        from /usr/share/fusor-installer/hooks/lib/base_wizard.rb:61:in `map'
        from /usr/share/fusor-installer/hooks/lib/base_wizard.rb:61:in `validate'
        from /usr/share/fusor-installer/hooks/lib/base_wizard.rb:38:in `start'
        from /usr/share/fusor-installer/hooks/lib/provisioning_wizard.rb:56:in `start'
        from /usr/share/fusor-installer/hooks/pre_validations/10-gather_and_set_fusor_values.rb:5:in `block (4 levels) in load'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hooking.rb:34:in `instance_eval'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hooking.rb:34:in `block (4 levels) in load'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hook_context.rb:13:in `instance_exec'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hook_context.rb:13:in `execute'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hooking.rb:51:in `block in execute'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hooking.rb:49:in `each'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/hooking.rb:49:in `execute'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/kafo_configure.rb:124:in `execute'
        from /usr/share/gems/gems/clamp-0.6.2/lib/clamp/command.rb:67:in `run'
        from /usr/share/gems/gems/clamp-0.6.2/lib/clamp/command.rb:125:in `run'
        from /usr/share/gems/gems/kafo-0.7.4/lib/kafo/kafo_configure.rb:150:in `run'
        from /usr/sbin/fusor-setup:73:in `<main>'
fusor-setup did not run properly.
Please correct the problem and try again.



Version-Release number of selected component (if applicable):
QCI-1.2-RHEL-7-20160713.t.1

How reproducible:
Every time.

Steps to Reproduce:
1.Enter appropriate values in the fusor-installer fields.
2.Then enter an invalid IP in the DHCP range start or DHCP range end fields
3.apply changes

Actual results:
Stack trace above.

Expected results:
The error to be gracefully caught.

Comment 1 Jason Montleon 2016-07-15 13:53:54 UTC
https://github.com/fusor/fusor-installer/pull/77


Note You need to log in before you can comment on or make changes to this bug.