Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1355701 - Remove or Use NumaNodeStatistics for VMs
Summary: Remove or Use NumaNodeStatistics for VMs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium vote
Target Milestone: ovirt-4.3.0
: ---
Assignee: nobody nobody
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-12 09:51 UTC by Roy Golan
Modified: 2018-06-26 15:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-26 15:43:12 UTC
oVirt Team: SLA
dfediuck: ovirt-4.3?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)

Description Roy Golan 2016-07-12 09:51:03 UTC
Description of problem:
There is a dead code for which is reading the VM nodes stats in VMs monitoring
but not saving it to db or performing any other thing.

VdsBrokerObjectsBuilder.java:2348

 public static List<VmNumaNode> buildVmNumaNodesRuntimeInfo(Map<String, Object> xmlRpcStruct)


The VmStatistics getter getvNumaNodeStatisticsList is never read by the dao i.e its not saved or read from db. 

I don't think any statistics about memory usage of the the vNuma is reported even by vdsm.


Some investigation needed to understand what was the purpose of introducing it. I guess that when we have the usage of the vnodes we could have present that to the user, not sure about further usage of it.

Comment 1 Red Hat Bugzilla Rules Engine 2016-07-12 09:51:52 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Martin Sivák 2018-06-26 15:43:12 UTC
I do not see the code anymore.


Note You need to log in before you can comment on or make changes to this bug.