Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1333928 - Review Request: python-searchlightclient - OpenStack Indexing and Search API Client Library
Summary: Review Request: python-searchlightclient - OpenStack Indexing and Search API ...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: FE-NEEDSPONSOR
Blocks: RDO-QUEENS
TreeView+ depends on / blocked
 
Reported: 2016-05-06 17:02 UTC by Alfredo Moralejo
Modified: 2017-09-28 15:24 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Alfredo Moralejo 2016-05-06 17:02:01 UTC
Spec URL: https://github.com/amoralej/python-searchlightclient/blob/master/python-searchlightclient.spec
SRPM URL: https://github.com/amoralej/python-searchlightclient/blob/master/python-searchlightclient-0.2.1-1.fc25.src.rpm
Description: OpenStack Indexing and Search API Client Library

Fedora Account System Username: amoralej

Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=13946267

Comment 1 Alfredo Moralejo 2016-05-06 17:04:06 UTC
This is my first package, so I'm adding FE-NEEDSPONSOR blocker.

Comment 4 Haïkel Guémar 2016-09-01 21:28:28 UTC
Missing epoch to keystoneclient, otherwise, it's good.

Comment 5 VincentS 2017-03-04 18:51:31 UTC
Hello, I'm not a reviewer but I have some comments on your review request.

First of all, there is a line too long in description.
$ rpmlint python-searchlightclient-0.2.1-1.fc25.src.rpm 
	python-searchlightclient.src: E: description-line-too-long C This is a client library for Searchlight built on the Searchlight API. It provides a Python API (the searchlightclient module) and a osc plugin for openstackclient CLI.

Then, I think you should use macros like that:
%global client python-searchlightclient 
^^
Should be %global client searchlightclient and

%global sclient searchlightclient
^^
delete this line which is useless then

Name:       %{client}
^^
should be python-%{client}

For more details and if you want do others review requests of python software, you should see https://fedoraproject.org/wiki/Packaging:Python

You could also use macro for summary to avoid repetitions.
Summary:    OpenStack Indexing and Search API Client Library
^^

Moreover, sources seems to be different from upstream.
$ sha256sum -b python-searchlightclient-0.2.1.tar.gz rpmbuild/SOURCES/python-searchlightclient-0.2.1.tar.gz 
	16494d6d9441b43ea77e65dee7c6423631198cadc24068c59f5947a6a37d2e70 *python-searchlightclient-0.2.1.tar.gz
	97a39ed792d3535740a91c71d9b22b198a07fdaf5ccb32043b8a09f8a21c1fd7 *rpmbuild/SOURCES/python-searchlightclient-0.2.1.tar.gz

Why do you add these dependancies ?
BuildRequires:  python-setuptools
BuildRequires:  git
BuildRequires:  python-hacking >= 0.10.2
BuildRequires:  python-coverage >= 3.6

Comment 6 VincentS 2017-03-05 18:35:02 UTC
I'm really sorry, I meant I'd rather do macros like this

%global client python-searchlightclient 
^^
%global client searchlightclient and

%global sclient searchlightclient
^^
delete this line

Name:       %{client}
^^
python-%{client}

because I think it would make the spec easier to understand, so what do you think ?

Comment 7 Haïkel Guémar 2017-09-28 15:24:49 UTC
Moved to Queens.


Note You need to log in before you can comment on or make changes to this bug.