Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1310124 - Review Request: nodejs-chalk0 - Terminal string styling done right
Summary: Review Request: nodejs-chalk0 - Terminal string styling done right
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeroen van Meeuwen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2016-02-19 14:20 UTC by Jared Smith
Modified: 2016-08-03 13:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-03 13:33:36 UTC


Attachments (Terms of Use)

Description Jared Smith 2016-02-19 14:20:31 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-chalk0/nodejs-chalk0.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-chalk0/nodejs-chalk0-0.4.0-5.fc24.src.rpm
Description: Terminal string styling done right
Fedora Account System Username: jsmith

Note that this is a split of the 0.4 series of nodejs-chalk, so that we can update the existing nodejs-chalk to the 1.x series

Comment 1 Jeroen van Meeuwen 2016-08-03 13:27:02 UTC
%check fails:

=============
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Gc2GAH
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ /usr/bin/mocha
  chalk
    1) should style string
    2) should support applying multiple styles at once
    3) should support nesting styles
    4) should reset all styles with `.reset()`
    5) should alias gray to grey
    6) should support variable number of arguments
    7) should support falsy values
    ✓ don't output escape codes if the input is empty
  chalk.enabled
    ✓ should not output colors when manually disabled
  chalk.styles
    ✓ should expose the styles as ANSI escape codes
  chalk.stripColor()
    ✓ should strip color from string
  4 passing (15ms)
  7 failing
  1) chalk should style string:
      AssertionError: 'foo' == '\u001b[4mfoo\u001b[24m'
      + expected - actual
      +foo
      -foo
      
      at Context.<anonymous> (test.js:8:10)
  2) chalk should support applying multiple styles at once:
      AssertionError: 'foo' == '\u001b[4m\u001b[42m\u001b[31mfoo\u001b[39m\u001b[49m\u001b[24m'
      + expected - actual
      +foo
      -foo
      
      at Context.<anonymous> (test.js:14:10)
  3) chalk should support nesting styles:
      AssertionError: 'foobar!' == '\u001b[31mfoo\u001b[44m\u001b[4mbar\u001b[24m\u001b[49m!\u001b[39m'
      + expected - actual
      +foobar!
      -foobar!
      
      at Context.<anonymous> (test.js:19:10)
  4) chalk should reset all styles with `.reset()`:
      AssertionError: 'foofoo' == '\u001b[0m\u001b[4m\u001b[42m\u001b[31mfoo\u001b[39m\u001b[49m\u001b[24mfoo\u001b[0m'
      + expected - actual
      +foofoo
      -foofoo
      
      at Context.<anonymous> (test.js:26:10)
  5) chalk should alias gray to grey:
      AssertionError: 'foo' == '\u001b[90mfoo\u001b[39m'
      + expected - actual
      +foo
      -foo
      
      at Context.<anonymous> (test.js:30:10)
  6) chalk should support variable number of arguments:
      AssertionError: 'foo bar' == '\u001b[31mfoo bar\u001b[39m'
      + expected - actual
      +foo bar
      -foo bar
      
      at Context.<anonymous> (test.js:34:10)
  7) chalk should support falsy values:
      AssertionError: '0' == '\u001b[31m0\u001b[39m'
      + expected - actual
      +0
      -0
      
      at Context.<anonymous> (test.js:38:10)
error: Bad exit status from /var/tmp/rpm-tmp.Gc2GAH (%check)
===========

Comment 2 Jared Smith 2016-08-03 13:33:36 UTC
This package is no longer needed, so I'm closing the package review.


Note You need to log in before you can comment on or make changes to this bug.