Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1302809 - Review Request: ne - ne, the nice editor
Summary: Review Request: ne - ne, the nice editor
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AwaitingSubmitter
Depends On:
Blocks: FE-NEEDSPONSOR FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2016-01-28 16:43 UTC by Brandon Thomas
Modified: 2016-07-15 12:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Brandon Thomas 2016-01-28 16:43:48 UTC
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/ne/ne.git/tree/ne.spec?id=2b507b12e4a1a6d1b0cbd1012858d115462a285b
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bthomas/ne/fedora-rawhide-x86_64/00156282-ne/ne-3.0.1-1.fc24.src.rpm
Description:  ne is a free (GPL'd) text editor based on the POSIX standard that runs (we hope) on almost any UN*X machine. ne is easy to use for the beginner, but powerful and fully configurable for the wizard, and most sparing in its resource usage. If you have the resources and the patience to use emacs or the right mental twist to use vi then probably ne is not for you. However, being fast, small, powerful and simple to use, ne is ideal for email, editing through phone line (or slow GSM/GPRS) connections and so on. Moreover, the internal text representation is very compact--you can easily load and modify very large files.

Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12712599

Fedora Account System Username: bthomas

Comment 1 Antonio Trande 2016-01-30 13:26:56 UTC
- Very short name; can you consider to use 'ne-editor' as package name?

Name:        ne-editor
Version:     3.0.1
Release:     1%{?dist}
Summary:     Nice text editor

- Source0 is a complete link to the archive

- cd src; make NE_GLOBAL_DIR=/usr/share/ne; strip ne

Use macros as much as possible and parallel 'make':

make -C src NE_GLOBAL_DIR=%{_datadir}/ne %{?_smp_mflags}; strip ne

http://fedoraproject.org/wiki/Packaging:RPMMacros

Comment 2 Mamoru TASAKA 2016-01-30 15:48:49 UTC
* %optflags
  - Honor %optflags. Current compilation does not other them.
    Also changing optimization level from -O2 is discouraged, please
    fix this.
    https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

* Debuginfo
  - Don't strip binary. This disables debuginfo rpm generation.
    (And as I said above, currently %optflags is not honored, including
     "-g". This is one of the reason why debuginfo file is not
     generated. Remove %global debug_package %{nil} and generate
     useful debuginfo rpm correctly)

    https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages
    https://fedoraproject.org/wiki/Packaging:Debuginfo

Comment 3 Petr Šabata 2016-02-01 09:24:00 UTC
(In reply to Antonio Trande from comment #1)
> - Very short name; can you consider to use 'ne-editor' as package name?

Hmm, I'm curious -- why is this an issue?  `ne' is the name of the project and
also the name of the binary.  Nobody's going to try installing `ne-editor' first.

I also maintain a few packages with two-letter names so I'm wondering why you
think it's problematic in any way.

Comment 4 Antonio Trande 2016-02-01 13:38:43 UTC
(In reply to Petr Šabata from comment #3)
> (In reply to Antonio Trande from comment #1)
> > - Very short name; can you consider to use 'ne-editor' as package name?
> Hmm, I'm curious -- why is this an issue?

It's not mandatory. If you prefer use a '2-letter' name I think there is not any rule that prevents this choice.
Even if I don't remember any package with name so short on Fedora.

Comment 5 Petr Šabata 2016-02-01 14:03:43 UTC
(In reply to Antonio Trande from comment #4)
> (In reply to Petr Šabata from comment #3)
> > (In reply to Antonio Trande from comment #1)
> > > - Very short name; can you consider to use 'ne-editor' as package name?
> > Hmm, I'm curious -- why is this an issue?
> 
> It's not mandatory. If you prefer use a '2-letter' name I think there is not
> any rule that prevents this choice.
> Even if I don't remember any package with name so short on Fedora.

Well, that doesn't really answer my question why you think it's strange or bad.

And just to name a few from the top of my head -- at, mc, nc, ii, jj, st, xz, bc, ... :)

Comment 6 Antonio Trande 2016-02-01 14:26:11 UTC
(In reply to Petr Šabata from comment #5)
> (In reply to Antonio Trande from comment #4)
> > (In reply to Petr Šabata from comment #3)
> > > (In reply to Antonio Trande from comment #1)
> > > > - Very short name; can you consider to use 'ne-editor' as package name?
> > > Hmm, I'm curious -- why is this an issue?
> > 
> > It's not mandatory. If you prefer use a '2-letter' name I think there is not
> > any rule that prevents this choice.
> > Even if I don't remember any package with name so short on Fedora.
> 
> Well, that doesn't really answer my question why you think it's strange or
> bad.
> 

It's not strange neither bad, just not easily recognizable during a searching. Who does not know 'ne', can easily understand what it is already by '-editor' suffix.
That is my thought of course.

> And just to name a few from the top of my head -- at, mc, nc, ii, jj, st,
> xz, bc, ... :)

Indeed, there are there.

Comment 7 Petr Šabata 2016-02-01 14:45:55 UTC
(In reply to Antonio Trande from comment #6)
> It's not strange neither bad, just not easily recognizable during a
> searching. Who does not know 'ne', can easily understand what it is already
> by '-editor' suffix.
> That is my thought of course.

Aha, I see.  Thanks.

Comment 8 Brandon Thomas 2016-02-06 15:00:24 UTC
For now I changed the name too "ne-editor" and made the other recommended changes. One thing that maybe should be considered is that other distributions (Arch, Ubuntu, Gentoo) call it "ne", but I'm not sure if that carries any weight.

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/ne/ne-editor.git/tree/ne.spec?id=aa715a3603b500fdefb5ade6f3021d23287132ac
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/bthomas/ne/fedora-rawhide-x86_64/00158379-ne-editor/ne-editor-3.0.1-1.fc24.src.rpm

Comment 9 Antonio Trande 2016-02-06 16:06:53 UTC
- You don't use macros yet:

rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT/usr/bin
mkdir -p $RPM_BUILD_ROOT/usr/share/ne/syntax
mkdir -p $RPM_BUILD_ROOT/usr/share/ne/macros
mkdir -p $RPM_BUILD_ROOT/%{_infodir}
mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1
mkdir -p $RPM_BUILD_ROOT/%{_docdir}/ne-%{version}/html

becomes

rm -rf $RPM_BUILD_ROOT
mkdir -p $RPM_BUILD_ROOT%{_bindir}
mkdir -p $RPM_BUILD_ROOT%{_datadir}/ne/syntax
mkdir -p $RPM_BUILD_ROOT%{_datadir}/ne/macros
mkdir -p $RPM_BUILD_ROOT/%{_infodir}
mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1
mkdir -p $RPM_BUILD_ROOT/%{_docdir}/ne-%{version}/html

- 
mkdir -p $RPM_BUILD_ROOT/%{_docdir}/ne-%{version}/html
mv doc/html .

you can do that with a simple

%doc doc/html

-
/usr/share/ne/syntax/*.jsf
/usr/share/ne/macros/*

becomes

%{_datadir}/ne/

to include all directories/files under /usr/share/ne

- %doc ./COPYING

Use %license for this file.

Comment 11 Antonio Trande 2016-02-11 17:23:26 UTC
(In reply to Brandon Thomas from comment #10)
> Thanks! Let me know how this looks.
> 
> Spec URL:
> http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/ne/ne-editor.git/tree/
> ne.spec?id=ed3485452bd4f741fd1ed058944f849c0d960f11
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/bthomas/ne/fedora-rawhide-
> x86_64/00159238-ne-editor/ne-editor-3.0.1-1.fc24.src.rpm

Changelog is not valid and not marked with %changelog macro.
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

Comment 12 Antonio Trande 2016-02-28 18:47:38 UTC
Stalled?

Comment 13 Antonio Trande 2016-03-09 17:39:33 UTC
Submitter does not reply.
Review stalled.


Note You need to log in before you can comment on or make changes to this bug.