Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1115664 - Review Request: nodejs-connect-livereload - Connect middleware for adding the livereload script to the response
Summary: Review Request: nodejs-connect-livereload - Connect middleware for adding the...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews 1115670
TreeView+ depends on / blocked
 
Reported: 2014-07-02 21:03 UTC by Ralph Bean
Modified: 2014-08-15 02:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-07-22 19:53:40 UTC
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Ralph Bean 2014-07-02 21:03:20 UTC
Spec URL: http://ralph.fedorapeople.org//nodejs-connect-livereload.spec
SRPM URL: http://ralph.fedorapeople.org//nodejs-connect-livereload-0.4.0-1.fc20.src.rpm

Description:
Connect middleware for adding the livereload script to the response.  No
browser plugin is needed.  If you are happy with a browser plugin, then you
don't need this middleware.

Comment 1 Parag AN(पराग) 2014-07-18 15:23:49 UTC
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-connect-livereload.src: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
nodejs-connect-livereload.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
nodejs-connect-livereload.x86_64: W: spelling-error Summary(en_US) middleware -> middle ware, middle-ware, middleweight
nodejs-connect-livereload.x86_64: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
nodejs-connect-livereload.x86_64: E: no-binary
nodejs-connect-livereload.x86_64: W: only-non-binary-in-usr-lib
nodejs-connect-livereload-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 5 warnings.

==> See suggestion below

+ Source verified with upstream as (sha256sum)
srpm tarball     :426ab32f280dd90281a8ba996ebe176fc5025838828b2ef4d35f6ea6e765411b
upstream tarball :426ab32f280dd90281a8ba996ebe176fc5025838828b2ef4d35f6ea6e765411b

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines


Suggestions:
1) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

Comment 3 Parag AN(पराग) 2014-07-22 03:25:58 UTC
Thanks for the update. New srpm looks good.

APPROVED.

Comment 4 Ralph Bean 2014-07-22 14:03:08 UTC
New Package SCM Request
=======================
Package Name: nodejs-connect-livereload
Short Description: Connect middleware for adding the livereload script to the response
Upstream URL: https://npmjs.org/package/connect-livereload
Owners: ralph
Branches: f21,f20,f19,epel7,el6
InitialCC:

Comment 5 Gwyn Ciesla 2014-07-22 14:36:33 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-07-22 19:48:17 UTC
nodejs-connect-livereload-0.4.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-connect-livereload-0.4.0-2.fc20

Comment 7 Fedora Update System 2014-07-22 19:48:28 UTC
nodejs-connect-livereload-0.4.0-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/nodejs-connect-livereload-0.4.0-2.fc19

Comment 8 Ralph Bean 2014-07-22 19:53:40 UTC
Buildroot overrides created.

Comment 9 Fedora Update System 2014-08-15 02:46:18 UTC
nodejs-connect-livereload-0.4.0-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 10 Fedora Update System 2014-08-15 02:52:14 UTC
nodejs-connect-livereload-0.4.0-2.fc20 has been pushed to the Fedora 20 stable repository.


Note You need to log in before you can comment on or make changes to this bug.