Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1059566 - Unexpected behavior of 'Fail' button
Summary: Unexpected behavior of 'Fail' button
Keywords:
Status: MODIFIED
Alias: None
Product: JBoss Fuse Service Works 6
Classification: JBoss
Component: DT Governance
Version: 6.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: FUTURE
Assignee: Eric Wittmann
QA Contact: Stefan Bunciak
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-30 08:14 UTC by Stefan Bunciak
Modified: 2015-02-16 10:09 UTC (History)
3 users (show)

Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)

Description Stefan Bunciak 2014-01-30 08:14:39 UTC
Description of problem:

* What happens when user click on the 'Fail' button in DTGov task form (SimpleReleaseProcess) is quite unpredictable.

Version-Release number of selected component (if applicable):
* FSW 6.0.0.CR4

How reproducible:


Steps to Reproduce:

1. Install FSW 6.0.0.CR4 (default installation including security manager) + deploy dtgov-workflows
2. Start FSW on localhost
3. Create new deployment in DTGov (via UI or Maven upload) 
4. Test Dev task:
	- Check 'Pass'/'Fail' and click 'Fail' button -> NullPointerException

17:53:57,143 WARN  [org.drools.persistence.SingleSessionCommandService] (http-localhost.localdomain/127.0.0.1:8080-30) Could not commit session: org.jbpm.workflow.instance.WorkflowRuntimeException: [overlord.demo.SimpleReleaseProcess:3 - Continue if PASS - Stop if FAIL:6] -- Exception when trying to evaluate constraint PASS in split Continue if PASS - Stop if FAIL

17:53:57,166 ERROR [org.jboss.as.ejb3] (http-localhost.localdomain/127.0.0.1:8080-30) JBAS014581: EJB 3.1 FR 13.3.3: BMT bean TaskApi should complete transaction before returning.
17:53:57,167 ERROR [org.jboss.as.ejb3.invocation] (http-localhost.localdomain/127.0.0.1:8080-30) JBAS014134: EJB Invocation failed on component TaskApi for method public org.overlord.dtgov.taskapi.types.TaskType org.overlord.dtgov.taskapi.TaskApi.failTask(org.overlord.dtgov.taskapi.types.TaskDataType,javax.servlet.http.HttpServletRequest,long) throws java.lang.Exception: javax.ejb.EJBException: JBAS014581: EJB 3.1 FR 13.3.3: BMT bean TaskApi should complete transaction before returning.

Caused by: java.lang.NullPointerException
	at SRAMPPackage.Process_SRAMPPackage$u46$Simple_Release_Process398580192.returnValueEvaluator2(Process_SRAMPPackage$u46$Simple_Release_Process398580192.java:20)
	at SRAMPPackage.Process_SRAMPPackage$u46$Simple_Release_Process398580192ReturnValueEvaluator2Invoker.evaluate(Process_SRAMPPackage$u46$Simple_Release_Process398580192ReturnValueEvaluator2Invoker.java:15)
	at org.jbpm.process.instance.impl.ReturnValueConstraintEvaluator.evaluate(ReturnValueConstraintEvaluator.java:129) [jbpm-flow-6.0.0-redhat-9.jar:6.0.0-redhat-9]

5. Once moved to Test QA
	- Check 'Pass' and Click 'Fail' button -> Successfully completed task and moved to Test Stage

6. Once moved to Test Stage
	- Check 'Fail' and Click 'Fail' button -> Successfully completed task and moved to Test Prod
7. Once moved to Test Prod
	- Check 'Fail' and Click 'Pass' button -> Successfully completed task, ProdFail was not set to the deployment so obviously the Process finished successfully although it shouldn't.

Comment 1 Kurt T Stam 2014-02-19 13:51:02 UTC
Calling 'FAIL' on a human task does not stop the workflow. In most cases it actually doesn't make sense to have a 'fail' button at all. We will hide the button unless a workflow setting explicitly tells the form to show it.

Comment 2 Kurt T Stam 2014-03-21 15:38:24 UTC
To fix merge 

https://github.com/Governance/dtgov/pull/156

into the prod branch

Comment 3 Gary Brown 2014-06-18 11:49:22 UTC
Merged in community, and will be available in 6.1.0.


Note You need to log in before you can comment on or make changes to this bug.