Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1056336 - Review Request: perl-WebService-Linode - <short summary here>
Summary: Review Request: perl-WebService-Linode - <short summary here>
Keywords:
Status: CLOSED DUPLICATE of bug 1058623
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-01-22 01:58 UTC by Nick Bebout
Modified: 2014-03-13 14:31 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-03-13 14:31:25 UTC


Attachments (Terms of Use)

Description Nick Bebout 2014-01-22 01:58:36 UTC
Spec URL: http://nb.fedorapeople.org/perl-WebService-Linode.spec
SRPM URL: http://nb.fedorapeople.org/perl-WebService-Linode-0.16-1.fc19.src.rpm
Description: Perl Interface to the Linode.com API
Fedora Account System Username: nb

Comment 1 kc8hfi 2014-01-22 03:39:53 UTC
It looks good to me.

Comment 2 Ralf Corsepius 2014-01-22 04:54:31 UTC
Nick, I feel you just submitted a raw cpanspec generated package.
Please understand, cpanspec is just a band-aid to assist perl-module packagers and does not generate clean spec. The spec-files it generates should be treated as templates and usually need manual refinement.


- The subject of this BZ is incomplete.
  Please fill out <short summary here>

- Source0: Points to a "by-modules" URL.
  Best-practice is to let it point to an "author"-URL.

- The %description needs improvements.

- Unless you also want to support CentOS,
BuildRoot:
...
rm -rf ${RPM_BUILD_ROOT}
...
%clean
...
%defattr()
can be removed

- Most of the explicit "Requires:" are redundant to those being automatically added by rpm and therefore should be removed.

- Though the sources tells this package would require Mozilla::CA, I can't spot any place inside of the sources, whete this package actually uses it.
Please check - May-be I am missing something, but I am inclined to believe this is an upstream packaging bug.

- Consider to add these "BuildRequire:":
perl(Carp)
perl(Data::Dumper)
perl(List::Util)
perl(strict)
perl(warnings)

Comment 3 Nick Bebout 2014-03-13 14:31:25 UTC

*** This bug has been marked as a duplicate of bug 1058623 ***


Note You need to log in before you can comment on or make changes to this bug.