Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1036230 - Review Request: faifa - Manages Intellon-based Power Line Communication devices
Summary: Review Request: faifa - Manages Intellon-based Power Line Communication devices
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2013-11-29 21:26 UTC by Eric Smith
Modified: 2015-12-20 13:07 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Eric Smith 2013-11-29 21:26:44 UTC
Spec URL: http://fedorapeople.org/~brouhaha/faifa/faifa.spec
SRPM URL: http://fedorapeople.org/~brouhaha/faifa/faifa-0.1-0.1.20131129git68cffbb.fc19.src.rpm
Description: 
Faifa can configure Power Line Communication devices (e.g. HomePlug AV)
using Qualcomm (formerly Intellon) chipsets.  It supports all
Intellon-specific management and control frames as well as standard
management frames.
Fedora Account System Username: brouhaha

Comment 1 Volker Fröhlich 2014-01-18 22:03:44 UTC
The development symlink for libfaifa is missing from the devel package. Upstream should adjust its build system to install the library with executable permissions.

hpav_cfg is under BSD license. Since it compiles into a single binary that is not linked to libfaifa, the package license should be "GPLv2+ and BSD".

The license must be included in the libs package, rather than the main package here, as the libs package can be installed without the main package.

The compiler warnings should be taken care of as well.

Comment 2 Eric Smith 2014-03-17 21:36:23 UTC
Thanks for looking at this.

I'm not completely certain that I understand the "development symlink" comment.  I reported upstream, but my explanation may not be accurate:
  https://github.com/ffainelli/faifa/issues/5

I reported the executable permissions issue and added a comment to the spec:
  https://github.com/ffainelli/faifa/issues/4

I moved the license and changed the License tag as you suggested.

I believe fixing compiler warnings is out of scope for Fedora packaging.

Updated to latest upstream git.

Spec URL: http://fedorapeople.org/~brouhaha/faifa/faifa.spec
SRPM URL: http://fedorapeople.org/~brouhaha/faifa/faifa-0.1-0.2.20140228git9f2dcd3.fc19.src.rpm


Note You need to log in before you can comment on or make changes to this bug.