Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1030968 - Review Request: python-micawber - Python library for extracting rich content from URLs
Summary: Review Request: python-micawber - Python library for extracting rich content ...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Sachidananda Urs
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW 1010741
TreeView+ depends on / blocked
 
Reported: 2013-11-15 12:33 UTC by Christopher Meng
Modified: 2017-02-13 15:36 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
surs: fedora-review?


Attachments (Terms of Use)

Description Christopher Meng 2013-11-15 12:33:15 UTC
Spec URL: http://cicku.me/python-micawber.spec
SRPM URL: http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm
Description: micawber is a small library for extracting rich content from URLs. It supplies a few methods for retrieving rich metadata about a variety of links, such as links to youtube videos. micawber also provides functions for parsing blocks of text and html and replacing links to videos with rich embedded content.
Fedora Account System Username: cicku

Comment 1 Mario Blättermann 2013-11-17 15:13:43 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6190605

$ rpmlint -i -v *python3-micawber.noarch: I: checking
python3-micawber.noarch: W: spelling-error Summary(en_US) urls -> curls, purls, hurls
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.

python3-micawber.noarch: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds)
python3-micawber.noarch: E: non-executable-script /usr/lib/python3.3/site-packages/examples/django_ex/manage.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python3-micawber.noarch: E: zero-length /usr/lib/python3.3/site-packages/micawber/contrib/mcdjango/mcdjango_tests/models.py
python3-micawber.noarch: E: zero-length /usr/lib/python3.3/site-packages/micawber/contrib/mcdjango/models.py
python-micawber.noarch: I: checking
python-micawber.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.

python-micawber.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube
The value of this tag appears to be misspelled. Please double-check.

python-micawber.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.

python-micawber.noarch: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds)
python-micawber.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/examples/django_ex/manage.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-micawber.noarch: E: zero-length /usr/lib/python2.7/site-packages/micawber/contrib/mcdjango/mcdjango_tests/models.py
python-micawber.noarch: E: zero-length /usr/lib/python2.7/site-packages/micawber/contrib/mcdjango/models.py
python-micawber.src: I: checking
python-micawber.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsal
The value of this tag appears to be misspelled. Please double-check.

python-micawber.src: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube
The value of this tag appears to be misspelled. Please double-check.

python-micawber.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
The value of this tag appears to be misspelled. Please double-check.

python-micawber.src: I: checking-url http://github.com/coleifer/micawber/ (timeout 10 seconds)
python-micawber.src:56: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:56: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:56: W: macro-in-comment %{__python2}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:57: W: macro-in-comment %{py3dir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:58: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:58: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src:58: W: macro-in-comment %{__python3}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.src: I: checking-url https://pypi.python.org/packages/source/m/micawber/micawber-0.3.0.tar.gz (timeout 10 seconds)
python-micawber.spec:56: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:56: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:56: W: macro-in-comment %{__python2}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:57: W: macro-in-comment %{py3dir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:58: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:58: W: macro-in-comment %{python_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec:58: W: macro-in-comment %{__python3}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

python-micawber.spec: I: checking-url https://pypi.python.org/packages/source/m/micawber/micawber-0.3.0.tar.gz (timeout 10 seconds)
3 packages and 1 specfiles checked; 6 errors, 24 warnings.

Please fix the file headers. We don't use the "env" style anymore, and scripts in %{python?_sitelib} don't use shebangs at all.

Escape the macros in the comments in the %check section to avoid unexpected behavior.

"urls" is a terrible construct. Use "URLs" instead.

Have a look at the test scripts. I don't assume that we really need empty files, unless they serve as placeholders for something. Otherwise, remove them.

Comment 2 Sachidananda Urs 2016-12-26 08:24:16 UTC
This is un-official review of the package:

Comment 3 Sachidananda Urs 2016-12-26 08:24:54 UTC
I'm not able to find the SRPM, the link is broken.

fedora-review -b 1030968
INFO: Processing bugzilla bug: 1030968
INFO: Getting .spec and .srpm Urls from : 1030968
INFO:   --> SRPM url: http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm
INFO:   --> Spec url: http://cicku.me/python-micawber.spec
INFO: Using review directory: /tmp/1030968-python-micawber
INFO: Downloading .spec and .srpm files
ERROR: 'Error 404 downloading http://cicku.me/python-micawber-0.3.0-1.fc21.src.rpm' (logs in /home/sac/.cache/fedora-review.log)


Note You need to log in before you can comment on or make changes to this bug.