|Summary:||kvm: $RPM_OPT_FLAGS not used|
|Product:||[Fedora] Fedora||Reporter:||Ville Skyttä <ville.skytta>|
|Component:||kvm||Assignee:||Jeremy Katz <katzj>|
|Status:||CLOSED RAWHIDE||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2007-02-26 21:00:48 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
Description Ville Skyttä 2007-02-25 22:53:46 UTC
http://www.redhat.com/archives/fedora-maintainers/2007-January/msg00339.html kvm is built without using $RPM_OPT_FLAGS. qemu/Makefile appears to support "make CFLAGS=..." builds, but user/Makefile doesn't (setting them that way will override some needed options or they all need to be redefined) so the fix is a bit more work than just that, preferably upstream...
Comment 1 Jeremy Katz 2007-02-25 23:23:45 UTC
Note that we definitely don't want RPM_OPT_FLAGS used for the qemu portions exactly for the same reasons that we don't want them for qemu in general (we're using gcc 3.4). kvmctl I'll have to look a little closer at to be more sure of what we want to do.
Comment 2 Ville Skyttä 2007-02-26 18:44:45 UTC
$RPM_OPT_FLAGS do not need to be used as is, but they should be used as the basis and unwanted options filtered out instead of ignoring everything. And some options from current optflags work with gcc 3.4 too. Rationale for deviating from them should also be documented in the specfile. http://fedoraproject.org/wiki/Packaging/Guidelines#CompilerFlags
Comment 3 Jeremy Katz 2007-02-26 21:00:48 UTC
There was a long thread on fedora-devel-list about why qemu _can't_ use the standard optflags if you want the dyngen stuff to keep working, though. Only partially due to gcc 3.4 (although istr there _are_ cases where things don't work with gcc 3.4) But made it so that we use RPM_OPT_FLAGS where it's appropriate to do so.