Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 228478

Summary: Review Request: hunspell-he - Hebrew hunspell dictionaries
Product: [Fedora] Fedora Reporter: Caolan McNamara <caolanm>
Component: Package ReviewAssignee: manuel wolfshant <wolfy>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: wolfy
Target Milestone: ---Flags: wolfy: fedora-review+
notting: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-02-14 10:41:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 163779    

Description Caolan McNamara 2007-02-13 10:30:11 UTC
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-he.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-he-0.20050112-1.src.rpm
Description: Hebrew hunspell dictionaries


Similar to 227811

Comment 1 manuel wolfshant 2007-02-13 15:56:07 UTC
GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
3214278f18109a350cdd765b8c43b1f6a8163e20  he_IL.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license GPL stated in the tag is the same as the web site says; upstream
does not really include the license but just a notice claiming that the
dictionary is licensed as GPL
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no need for -doc and no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- no need for -docs as the only doc is a 10 lines text file
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

SHOULD: upstream should be requested to include the license in the archive

Comment 2 Caolan McNamara 2007-02-14 10:41:41 UTC
 27554 (hunspell-he): Build on target fedora-development-extras succeeded.