Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1692897

Summary: sosreport should not modify OpenShift projects by default
Product: Red Hat Enterprise Linux 7 Reporter: Pablo Alonso Rodriguez <palonsor>
Component: sosAssignee: Pavel Moravec <pmoravec>
Status: VERIFIED --- QA Contact: Miroslav HradĂ­lek <mhradile>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.6CC: agk, bmr, gavin, mhradile, plambri, sbradley
Target Milestone: rcKeywords: OtherQA
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: sos-3.7-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Pablo Alonso Rodriguez 2019-03-26 16:29:27 UTC
Description of problem:

By default, oc adm diagnostics is run in such a way that it can make modifications to a running cluster. In unstable scenarios, this can amplify the issue.

I know there is a origin.diag-prevent option that may make oc adm diagnostics, run with --prevent-modification , preventing such modifications. 

However, this option is "off" by default, so it is very easy for a customer not to have it setup and, hence, end up running a non read-only oc adm diagnostics that may make even more harm to his cluster. Because of this, origin.diag-prevent option should be "on" by default.

Comment 2 Pablo Alonso Rodriguez 2019-03-26 17:07:31 UTC
Created pull request:

https://github.com/sosreport/sos/pull/1624

Comment 3 Pavel Moravec 2019-03-26 20:04:50 UTC
seems trivial change, devel_ack+ (maye still to 7.7, no guarantee though)