Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1691505

Summary: openshift-controller-manager-operator does not report 'Progressing=true' during daemonset rollout
Product: OpenShift Container Platform Reporter: Adam Kaplan <adam.kaplan>
Component: BuildAssignee: Corey Daley <cdaley>
Status: VERIFIED --- QA Contact: wewang <wewang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.1CC: aos-bugs, wzheng
Target Milestone: ---   
Target Release: 4.1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Adam Kaplan 2019-03-21 18:45:02 UTC
Description of problem: During a daemonset rollout, the openshift-controller-manager-operator reports that it is not progressing, even though the operand (openshift-controller-manager) is rolling out an update.


Version-Release number of selected component (if applicable): 4.0.0-0.alpha-2019-03-21-045513


How reproducible: Always


Steps to Reproduce:
1. Push a custom version of origin-hypershift to an external registry (ex: quay.io)
2. Set the openshift-controller-manager-operator to be unmanaged:
  a. oc edit clusterversion/version
  b. Add the following:
```
spec:
  overrides:
  - kind: Deployment
    name: openshift-controller-manager-operator
    namespace: openshift-controller-manager-operator
    unmanaged: true
``
3. Update the openshift-controller-manager-operator to deploy your custom version of origin-hypershift:
  a. oc edit deployment openshift-controller-manager-operator -n openshift-controller-manager-operator
  b. Update the IMAGE env var in the deployment:
```
spec:
...
  env:
  - name: IMAGE
    value: quay.io/myusername/origin-hypershift:mytag
...
```

Actual results: oc get clusteroperator/openshift-controller-manager always returns Progressing=false


Expected results: oc get clusteroperator/openshift-controller-manager should return Progressing=true during the daemonset rollout


Additional info:

Comment 1 Adam Kaplan 2019-04-04 13:13:51 UTC
Corey - this may be end up being a duplicate of 1694216. Once your fix is in we can re-evaluate.

Comment 2 Adam Kaplan 2019-04-11 12:55:57 UTC
Corey's openshift-controller-manager-operator PR: https://github.com/openshift/cluster-openshift-controller-manager-operator/pull/85

Comment 4 wewang 2019-04-16 05:41:58 UTC
When the daemonset rollout, clusteroperator/openshift-controller-manager returns Progressing=true now
version:
4.1.0-0.ci-2019-04-15-224704

logs:
I0416 03:35:30.231803       1 status_controller.go:152] clusteroperator/openshift-controller-manager diff {"status":{"conditions":[{"lastTransitionTime":"2019-04-16T03:35:29Z","reason":"AsExpected","status":"False","type":"Failing"},{"lastTransitionTime":"2019-04-16T03:35:30Z","message":"Progressing: daemonset/controller-manager: observed generation is 6, desired generation is 7.\nProgressing: openshiftcontrollermanagers.operator.openshift.io/cluster: observed generation is 3, desired generation is 4.","reason":"Progressing","status":"True","type":"Progressing"},{"lastTransitionTime":"2019-04-16T03:35:29Z","reason":"AsExpected","status":"True","type":"Available"},{"lastTransitionTime":"2019-04-16T03:35:29Z","reason":"NoData","status":"Unknown","type":"Upgradeable"}],"versions":[{"name":"operator","version":"4.1.0-0.ci-2019-04-15-224704"}]}}
I0416 03:35:30.237320       1 event.go:221] Event(v1.ObjectReference{Kind:"Deployment", Namespace:"openshift-controller-manager-operator", Name:"openshift-controller-manager-operator", UID:"996a0c7e-5fec-11e9-bae2-0279093214fc", APIVersion:"apps/v1", ResourceVersion:"", FieldPath:""}): type: 'Normal' reason: 'OperatorStatusChanged' Status for operator openshift-controller-manager changed: Progressing changed from False to True ("Progressing: daemonset/controller-manager: observed generation is 6, desired generation is 7.\nProgressing: openshiftcontrollermanagers.operator.openshift.io/cluster: observed generation is 3, desired generation is 4.")