Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1686753

Summary: Review Request: perl-Class-Measure - Create, compare and convert units of measurement
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Class-Measure-0.06-1.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-11 14:03:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1686788    

Description Petr Pisar 2019-03-08 09:16:57 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Class-Measure/perl-Class-Measure.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Class-Measure/perl-Class-Measure-0.06-1.fc31.src.rpm
Description:
This Perl module allows you to create, compare and convert units of
measurement.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-08 11:56:06 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Class-Measure-0.06-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(Class::Measure)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(overload)
      1 perl(strict)
      1 perl(Sub::Exporter) >= 0.982 
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Class-Measure-0.06-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Class::Measure) = 0.06
      1 perl-Class-Measure = 0.06-1.fc30
      1 perl(Class::Measure::Length) = 0.06
Binary provides are Ok.

$ rpmlint ./perl-Class-Measure*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-03-11 13:47:32 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Class-Measure

Comment 3 Petr Pisar 2019-03-11 14:03:02 UTC
Thank you for the review and the repository.