Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 162370

Summary: comparisons like X<=Y<=Z do not have their mathematical meaning
Product: [Fedora] Fedora Reporter: David Binderman <dcb314>
Component: librsvg2Assignee: Matthias Clasen <mclasen>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-08-16 15:25:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description David Binderman 2005-07-03 12:02:08 UTC
Description of problem:

I just tried to compile package librsvg2-2.9.5-2 from Redhat
Fedora Core development tree with the gcc 4.0.0 compiler and
the compiler flag -Wall.

The compiler said

rsvg-shapes.c:1845: warning: comparisons like X<=Y<=Z do not have their
mathematical meaning

The source code is

	if (height * *w >
		width * *h != (aspect_ratio & RSVG_ASPECT_RATIO_SLICE))

I agree with the compiler. Suggest code rework for maintainability.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Matthias Clasen 2005-08-16 15:25:15 UTC
librsvg cvs has added parens there to clarify the meaning.