Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1366196

Summary: Multiple Finalizing steps are created when executing COCO flow with child commands ending by themselves
Product: [oVirt] ovirt-engine Reporter: Liron Aravot <laravot>
Component: BLL.InfraAssignee: Liron Aravot <laravot>
Status: CLOSED CURRENTRELEASE QA Contact: Lucie Leistnerova <lleistne>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0.2CC: bugs, gklein, mperina, oourfali, tnisan
Target Milestone: ovirt-4.1.0-alphaKeywords: CodeChange
Target Release: 4.1.0Flags: rule-engine: ovirt-4.1+
rule-engine: planning_ack+
tnisan: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1367438 (view as bug list) Environment:
Last Closed: 2017-02-01 14:46:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Liron Aravot 2016-08-11 09:41:36 UTC
Description of problem:
When executing commands using the COCO infrastructure, we might choose
that those child commands will end by themselves, without the parent executing
their endAction().
On that case, the finalizing step of the job will be created multiple times.

Actual results:
The FINALIZING step is created multiple times

Expected results:
The FINALIZING step should be created once

Additional info:

Comment 1 Liron Aravot 2016-11-28 13:22:06 UTC
Steps to reproduce:
1. Have a 4.1 DC with a host
2. Create a VM with an image disk
3. Create 2 snapshots of the VM that includes the disk
4. Attempt to move the disk
5. Check the tasks sub tab, expand the job and verify that there's one finalizing step for the job (some of the job steps will have finalizing step as well).

Comment 2 Sandro Bonazzola 2016-12-12 13:53:45 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 3 Lucie Leistnerova 2017-02-01 07:13:14 UTC
moving disk has only one finalizing step

verified in ovirt-engine-4.1.0.3-0.1.el7.noarch