Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1364644

Summary: Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running tests with Mocha
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Jeroen van Meeuwen <vanmeeuwen+fedora>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review
Target Milestone: ---Flags: vanmeeuwen+fedora: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-12 17:12:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1364643    
Bug Blocks: 956806, 1387531    

Description Jared Smith 2016-08-06 08:07:41 UTC
Spec URL:
Description: A simple wrapper for running tests with Mocha
Fedora Account System Username: jsmith

Comment 1 Jeroen van Meeuwen 2016-08-07 10:35:56 UTC
This one does have rpmlint complain about the wrong interpreter as well. You mentioned the use of /usr/bin/node over /usr/bin/env node was not a packaging guideline yet ratified.

I take it this may involve, but the main reasons listed there are not my concern. The RPM dependency side-note is a bigger concern. My main concern is the ability to manipulate what is executed by the user (say, env node=~/bin/node and worse).

In any case, rpmlint reports it as an error;

nodejs-grunt-simple-mocha.noarch: E: wrong-script-interpreter /usr/lib/node_modules/grunt-simple-mocha/bin/grunt-simple-mocha /usr/bin/env node

Comment 3 Gwyn Ciesla 2016-08-11 13:40:13 UTC
Package request has been approved:

Comment 4 Jared Smith 2016-08-12 17:12:31 UTC
In rawhide, closing bug

Comment 5 Jared Smith 2016-08-12 17:17:45 UTC
In rawhide, closing bug