Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1269670

Summary: Review Request: nodejs-mime-types - The ultimate javascript content-type utility
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Troy Dawson <tdawson>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, piotr1212, tdawson
Target Milestone: ---Flags: tdawson: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-06 12:17:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1269658    
Bug Blocks: 956806, 1387531, 994934, 1269676    

Description Jared Smith 2015-10-07 21:50:06 UTC
Spec URL:
Description: The ultimate javascript content-type utility
Fedora Account System Username: jsmith

$ rpmlint nodejs-mime-types.spec nodejs-mime-types-2.1.7-1.fc23.src.rpm 
nodejs-mime-types.src: W: spelling-error Summary(en_US) javascript -> java script, java-script, JavaScript
nodejs-mime-types.src: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
1 packages and 1 specfiles checked; 0 errors, 2 warnings.

Depends on nodejs-mime-db being reviewed in bug #1269658.

Comment 1 Troy Dawson 2015-10-19 20:47:43 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- Package installs properly.
  Note: Installation errors (see attachment)

===== MUST items =====

[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[X]: License field in the package spec file matches the actual license.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
[x]: Spec file according to URL is the same as in SRPM.

Installation errors
INFO: version 1.2.13 starting (python version = 3.4.3)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled dnf cache
Start: cleaning dnf metadata
Finish: cleaning dnf metadata
INFO: enabled ccache
Mock Version: 1.2.13
INFO: Mock Version: 1.2.13
Finish: chroot init
INFO: installing package(s): /home/quake/review/1269670-nodejs-mime-types/results/nodejs-mime-types-2.1.7-1.fc24.noarch.rpm
ERROR: Command failed. See logs for output.
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 install /home/quake/review/1269670-nodejs-mime-types/results/nodejs-mime-types-2.1.7-1.fc24.noarch.rpm --setopt=tsflags=nocontexts

Checking: nodejs-mime-types-2.1.7-1.fc24.noarch.rpm
nodejs-mime-types.noarch: W: spelling-error Summary(en_US) javascript -> java script, java-script, JavaScript
nodejs-mime-types.noarch: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
nodejs-mime-types.noarch: W: only-non-binary-in-usr-lib
nodejs-mime-types.noarch: W: dangling-symlink /usr/lib/node_modules/mime-types/node_modules/mime-db /usr/lib/node_modules/mime-db
nodejs-mime-types.src: W: spelling-error Summary(en_US) javascript -> java script, java-script, JavaScript
nodejs-mime-types.src: W: spelling-error %description -l en_US javascript -> java script, java-script, JavaScript
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

nodejs-mime-types (rpmlib, GLIBC filtered):


Source checksums
---------------- :
  CHECKSUM(SHA256) this package     : a2eefbdff43a6df08dc6d3ea7df644d92320b14af9250962aae903c2a237ed7c
  CHECKSUM(SHA256) upstream package : a2eefbdff43a6df08dc6d3ea7df644d92320b14af9250962aae903c2a237ed7c

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1269670
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Comment 2 Troy Dawson 2015-10-19 20:48:20 UTC
Looks great.  Package approved.

Comment 3 Tom Hughes 2015-10-25 16:51:24 UTC
*** Bug 1275075 has been marked as a duplicate of this bug. ***

Comment 4 Piotr Popieluch 2015-10-25 18:33:16 UTC
Missed that this was already packaged and in review.. 

Comparing my version to this one, please consider:

- Use github source guidelines [1]
- We should build from source, see [2]
- Don't think that src dir needs to be packaged

Thanks for packaging


Comment 5 Piotr Popieluch 2015-10-25 18:37:19 UTC
Sorry, my last comment was targeted at nodejs-mime-db, not this bug..

Comment 6 Piotr Popieluch 2015-12-06 12:17:54 UTC
This is built in rawhide, closing so it won't block other bugs.