|Product:||[Fedora] Fedora||Reporter:||Jared Smith <jsmith.fedora>|
|Component:||Package Review||Assignee:||Troy Dawson <tdawson>|
|Status:||CLOSED RAWHIDE||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Version:||rawhide||CC:||package-review, piotr1212, tdawson|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2015-12-06 12:17:54 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
|Bug Depends On:||1269658|
|Bug Blocks:||956806, 1387531, 994934, 1269676|
Description Jared Smith 2015-10-07 21:50:06 UTC
Comment 1 Troy Dawson 2015-10-19 20:47:43 UTC
Comment 2 Troy Dawson 2015-10-19 20:48:20 UTC
Looks great. Package approved.
Comment 3 Tom Hughes 2015-10-25 16:51:24 UTC
*** Bug 1275075 has been marked as a duplicate of this bug. ***
Comment 4 Piotr Popieluch 2015-10-25 18:33:16 UTC
Missed that this was already packaged and in review.. Comparing my version to this one, please consider: - Use github source guidelines  - We should build from source, see  - Don't think that src dir needs to be packaged Thanks for packaging  https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services  https://github.com/jshttp/mime-db/blob/master/package.json#L43
Comment 5 Piotr Popieluch 2015-10-25 18:37:19 UTC
Sorry, my last comment was targeted at nodejs-mime-db, not this bug..
Comment 6 Piotr Popieluch 2015-12-06 12:17:54 UTC
This is built in rawhide, closing so it won't block other bugs.