Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.

Bug 1096864

Summary: atlascpp make check failure since -Werror=format-security
Product: [Fedora] Fedora Reporter: Michel Normand <normand>
Component: atlascppAssignee: Martin Preisler <mpreisle>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: atorkhov, bruno, mpreisle, rosset.filipe
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-16 02:08:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1051573    

Description Michel Normand 2014-05-12 14:34:37 UTC
Description of problem: atlascpp make check failure since -Werror=format-security


Version-Release number of selected component (if applicable):
atlascpp-0.6.2-6.fc21

How reproducible:


Steps to Reproduce:
1. fedpkg clone -a atlascpp
2. fedpkg mockbuild

Actual results:
===
...
make[3]: Entering directory `/builddir/build/BUILD/Atlas-C++-0.6.2/tests/Objects'
g++ -DHAVE_CONFIG_H  -I../..    -O2 -g -pipe -Wall =format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -DNDEBUG -c -o custom_ops.o custom_ops.cpp
g++: error: =format-security: No such file or directory
make[3]: *** [custom_ops.o] Error 1
===

Additional info:
The failure is related to the sed lines in atlascpp.spec that need to be changed
as suggested by following diff:
===
$git diff
diff --git a/atlascpp.spec b/atlascpp.spec
index 67d6d83..1da6188 100644
--- a/atlascpp.spec
+++ b/atlascpp.spec
@@ -45,8 +45,8 @@ Libraries and header files for developing applications that use Atlas-C++
 
 # simple hack to remove -Werror from the test suite, which causes
 # it to fail.
-sed -i -e 's#-Werror##' benchmark/Makefile
-sed -i -e 's#-Werror##' tests/Objects/Makefile
+sed -i -e 's#-Werror\(=[^ ]*\)\?##' benchmark/Makefile
+sed -i -e 's#-Werror\(=[^ ]*\)\?##' tests/Objects/Makefile
 
 make %{?_smp_mflags}
 make docs
===